[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik created this revision.
shafik added reviewers: aaron.ballman, erichkeane, thakis, mstorsjo, rsmith.
Herald added a project: All.
shafik requested review of this revision.

Previously we allowed the ability to downgrade this diagnostic based on feedback that time was needed to fix code: D131307 <https://reviews.llvm.org/D131307>

We believe sufficient time has passed and we will turn this back into a hard error.

This will also fix some bugs that were a consequence of the workaround:

https://github.com/llvm/llvm-project/issues/62355
https://github.com/llvm/llvm-project/issues/57176


https://reviews.llvm.org/D150226

Files:
  clang/include/clang/Basic/DiagnosticASTKinds.td
  clang/lib/AST/ExprConstant.cpp
  clang/test/SemaCXX/constant-expression-cxx11.cpp
  clang/test/SemaCXX/cxx2a-consteval.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150226.520818.patch
Type: text/x-patch
Size: 9634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230509/e67b7674/attachment-0001.bin>