[PATCH] D143260: [clangd] Add semantic token for labels

Tue May 9 01:37:31 PDT 2023

ckandeler added a comment.

In D143260#4328948 <https://reviews.llvm.org/D143260#4328948>, @kadircet wrote:

> Considering that we have added a bunch of token kinds, let me ask you another question then, how many more new token kinds do we expect to have? e.g. if label is the last one sure, but if we plan to have 10 more or if we don't know how many more we would like to have, i think it's better to first come up with a plan and an agreement to make sure we can avoid such discussions with every attempt. does that sound fair?

Speaking for myself, I don't currently have any plans to add further tokens, but it's difficult to say with certainty that this will be the last one. For instance, new C++ features in future standards might suggest new token types (like "concept" for C++20). And if https://github.com/clangd/clangd/issues/1115 gets implemented, then there will be "string", "number" and "keyword", though these are all part of the LSP spec already.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143260/new/

https://reviews.llvm.org/D143260