[PATCH] D143260: [clangd] Add semantic token for labels

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

In D143260#4328948 <https://reviews.llvm.org/D143260#4328948>, @kadircet wrote:

> Considering that we have added a bunch of token kinds, let me ask you another question then, how many more new token kinds do we expect to have? e.g. if label is the last one sure, but if we plan to have 10 more or if we don't know how many more we would like to have, i think it's better to first come up with a plan and an agreement to make sure we can avoid such discussions with every attempt. does that sound fair?

That's a totally fair question.

For my part, I don't have any additional token kinds in mind to add. (The suggestion in https://github.com/clangd/clangd/issues/787 to split "template parameter" into type vs. non-type is an interesting one, but it's more like a nice-to-have enhancement.)

Not sure about Qt Creator, will let @ckandeler chime in on whether he had any other token kinds in mind for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143260/new/

https://reviews.llvm.org/D143260