[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

[NAKAMURA Takumi via Phabricator via cfe-commits]

chapuni added a comment.

In D148767#4312692 <https://reviews.llvm.org/D148767#4312692>, @barannikov88 wrote:

> Sorry, I don't follow. They may theoretically depend on anything. Why CodeGen/CodeGenTypes, specifically?
> If they don't require it, why add it?

I added deps pessimistically, "This depends on CodeGenTypes if LowLevelType.h is included".

In D148767#4315667 <https://reviews.llvm.org/D148767#4315667>, @jobnoorman wrote:

> Hi, this seems to have broken my bolt+debug+shared build. I don't think there are build bots for this configuration but you can reproduce it like this:

Sorry for inconvenience. Could you add `CodeGenTypes` in `LINK_COMPONENTS` please?

In D148767#4315757 <https://reviews.llvm.org/D148767#4315757>, @vzakhari wrote:

> I can add `CodeGenTypes` link component in `flang/lib/Optimizer/Transforms/CMakeLists.txt`, but I am worried about the comment in `llvm/lib/CodeGen/CMakeLists.txt`:
>
>   # Be careful to append deps on this, since Targets' tablegens depend on this.
>   add_llvm_component_library(LLVMCodeGenTypes
>
> I am not sure whether I need to be careful about adding dependencies onto `LLVMCodeGenTypes` (as I am planning to do) or about adding dependencies for `LLVMCodeGenTypes` target in `llvm/lib/CodeGen/CMakeLists.txt` :)

The latter. Excuse my wrong wording.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767