[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

Slava Zakharin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 3 09:18:31 PDT 2023


vzakhari added a comment.

In D148767#4315667 <https://reviews.llvm.org/D148767#4315667>, @jobnoorman wrote:

> Hi, this seems to have broken my bolt+debug+shared build. I don't think there are build bots for this configuration but you can reproduce it like this:

Same with flang+debug+shared build:

  ld.lld: error: undefined symbol: llvm::LLT::print(llvm::raw_ostream&) const
  >>> referenced by LowLevelType.h:269 (/llvm-project/llvm/include/llvm/CodeGen/LowLevelType.h:269)
  >>>               CMakeFiles/obj.FIRTransforms.dir/SimplifyIntrinsics.cpp.o:(llvm::LLT::dump() const)

I can add `CodeGenTypes` link component in `flang/lib/Optimizer/Transforms/CMakeLists.txt`, but I am worried about the comment in `llvm/lib/CodeGen/CMakeLists.txt`:

  # Be careful to append deps on this, since Targets' tablegens depend on this.
  add_llvm_component_library(LLVMCodeGenTypes

I am not sure whether I need to be careful about adding dependencies onto `LLVMCodeGenTypes` (as I am planning to do) or about adding dependencies for `LLVMCodeGenTypes` target in `llvm/lib/CodeGen/CMakeLists.txt` :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148767/new/

https://reviews.llvm.org/D148767



More information about the cfe-commits mailing list