[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

[Andrey Ali Khan Bolshakov via Phabricator via cfe-commits]

bolshakov-a added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250
+      for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I)
+        mangleSourceName("<unnamed-tag>");
+
----------------
efriedma wrote:
> bolshakov-a wrote:
> > efriedma wrote:
> > > Weird indentation
> > I agree. Don't know why clang-format does so. Should I put `clang-format off` here?
> If clang-format won't cooperate, you can probably make it figure out what you're doing with something like
> 
>   if (const auto *ID = dyn_cast<IndirectFieldDecl>(ND)) {
>     for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I)
>       mangleSourceName("<unnamed-tag>");
>   }
It doesn't help. Moreover, clang-format corrupts formatting in this function even without my changes. You can check it by yourself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146386/new/

https://reviews.llvm.org/D146386