[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 28 12:58:53 PDT 2023


efriedma added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250
+      for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I)
+        mangleSourceName("<unnamed-tag>");
+
----------------
bolshakov-a wrote:
> efriedma wrote:
> > Weird indentation
> I agree. Don't know why clang-format does so. Should I put `clang-format off` here?
If clang-format won't cooperate, you can probably make it figure out what you're doing with something like

  if (const auto *ID = dyn_cast<IndirectFieldDecl>(ND)) {
    for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I)
      mangleSourceName("<unnamed-tag>");
  }


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146386/new/

https://reviews.llvm.org/D146386



More information about the cfe-commits mailing list