[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

Thu Apr 27 06:56:36 PDT 2023

TIFitis added a comment.

In D146557#4295550 <https://reviews.llvm.org/D146557#4295550>, @kiranchandramohan wrote:

> In D146557#4292223 <https://reviews.llvm.org/D146557#4292223>, @TIFitis wrote:
>
>> Cleaned up how IsBegin argument is passed for createTargetData call.
>
> Please submit this directly as an NFC patch.

I have merged it separately.

> We should always work towards simple patches that are easy to review. Sometimes a big patch is required to give the full context. But it can then be broken up into small patches for faster review. I have created D149153 <https://reviews.llvm.org/D149153> for the `inlineConvertOmpRegions` change.

Thanks for creating your patch. I'll try to make my patches shorter in the future.

Once D149153 <https://reviews.llvm.org/D149153> is merged I'll rebase this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146557/new/

https://reviews.llvm.org/D146557