[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

Kiran Chandramohan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 25 06:16:00 PDT 2023


kiranchandramohan added a comment.

In D146557#4292223 <https://reviews.llvm.org/D146557#4292223>, @TIFitis wrote:

> Cleaned up how IsBegin argument is passed for createTargetData call.

Please submit this directly as an NFC patch.

We should always work towards simple patches that are easy to review. Sometimes a big patch is required to give the full context. But it can then be broken up into small patches for faster review. I have created D149153 <https://reviews.llvm.org/D149153> for the `inlineConvertOmpRegions` change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146557/new/

https://reviews.llvm.org/D146557



More information about the cfe-commits mailing list