[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string&

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: lld/COFF/Symbols.cpp:43
     if (demangled != demangleInput)
-      return prefix + demangle(demangleInput.str());
+      return prefix + demangle(demangleInput);
     return (prefix + prefixless).str();
----------------
probably should just be `return prefix + demangled;`


================
Comment at: llvm/docs/ReleaseNotes.rst:291
+  ``const std::string&``. Be careful passing temporaries into
+  ``llvm::demangle`` that don't outlive the expressing using
+  ``llvm::demangle``.
----------------
expression


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149104/new/

https://reviews.llvm.org/D149104