[PATCH] D149104: [Demangle] make llvm::demangle take std::string_view rather than const std::string&

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 24 16:49:39 PDT 2023


MaskRay added inline comments.


================
Comment at: lld/ELF/Symbols.cpp:50
+    std::string root = symName.str();
+    return demangle(root);
+  }
----------------
`return demangle(symName.str());`

perhaps `return demangle(symName);` works as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149104/new/

https://reviews.llvm.org/D149104



More information about the cfe-commits mailing list