[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type
Yueh-Ting (eop) Chen via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 24 03:11:06 PDT 2023
eopXD marked 2 inline comments as done.
eopXD added inline comments.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:2723
+ unsigned MaxIndex = cast<StructType>(VTupleOperand->getType())->getNumElements();
+ Index = std::min(Index, MaxIndex);
+
----------------
craig.topper wrote:
> craig.topper wrote:
> > Does SemaChecking.cpp already guarantee Index is less than Maxindex?
> Actually it looks like maybe SemaChecking considers MaxIndex to be LMUL*NF? Does that mean vget can extract an LMUL1 value from an LMUL4 tuple?
Modified code under SemaChecking.cpp for vector tuple types.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147916/new/
https://reviews.llvm.org/D147916
More information about the cfe-commits
mailing list