[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 23 03:37:42 PDT 2023


PiotrZSL added a comment.

Thank you for your feedback regarding the code review. I understand that the review includes the removal of 35 lines and the addition of 42 lines. However, I would like to point out that the areStatementsIdentical function and the other function in question are only around 24 lines long each. Therefore, I believe that the changes made to these functions are not overly complex and can be easily reviewed as they are currently presented.

Additionally, I would like to express my concern that pushing anything through the review process currently takes up to a month. Separating the changes into two patches would only prolong this process and potentially delay the completion of this task.

If you have any questions related to the scope of the changes, I would be more than happy to answer them.

Thank you again for your time and feedback. Please let me know if you have any further concerns, and I'll do my best to address them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148995/new/

https://reviews.llvm.org/D148995



More information about the cfe-commits mailing list