[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 23 03:09:53 PDT 2023


carlosgalvezp added a comment.

Thanks for the refactoring, great to remove some code duplication!

As a reviewer it's not possible for me to confidently review the functional changes to `areStatementsIdentical`, since they don't show side by side as they are in different files. Please perform the move in one NFC patch, and apply the functional changes in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148995/new/

https://reviews.llvm.org/D148995



More information about the cfe-commits mailing list