[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

[Mariusz Sikora via Phabricator via cfe-commits]

mariusz-sikora-at-amd added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4491
+    // the builtin.
+    TheCall->setType(Context.VoidTy);
+    return false;
----------------
arsenm wrote:
> I'm assuming mutating the AST is very not OK
I based my changes on how __sync_* is handled in SemaBuiltinAtomicOverloaded. You suggest to just add additional builtins with suffix _not_ret ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148796/new/

https://reviews.llvm.org/D148796