[PATCH] D148796: [AMDGPU][GFX908] Add builtin support for global add atomic f16/f32

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added a comment.

I thought we had separate _rtn* builtins for this?



================
Comment at: clang/lib/Sema/SemaChecking.cpp:4484
+    auto TargetID = Context.getTargetInfo().getTargetID();
+    if (!TargetID || TargetID->find("gfx908") == std::string::npos)
+      return false;
----------------
Would need something better to test


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4491
+    // the builtin.
+    TheCall->setType(Context.VoidTy);
+    return false;
----------------
I'm assuming mutating the AST is very not OK


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148796/new/

https://reviews.llvm.org/D148796