[PATCH] D148148: [clang] Bump AS_GNU to 1

Wed Apr 12 10:56:50 PDT 2023

erichkeane added inline comments.

================
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135

   AttributeCommonInfo(const IdentifierInfo *AttrName,
                       const IdentifierInfo *ScopeName, SourceRange AttrRange,
----------------
rsandifo-arm wrote:
> erichkeane wrote:
> > Did these two ctors swap places somehow?  There's something goofy going on here?  Or is this just to make the delegation of ctors more sensible? 
> Ah, yeah, I should have mentioned that, sorry.  The most general constructor was previously the second in the list.  Like you say, I moved it up to make the delegation more obvious.  The other three keep their relative order.
Thanks for explaining, sounds good to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148148/new/

https://reviews.llvm.org/D148148