[PATCH] D148148: [clang] Bump AS_GNU to 1
Richard Sandiford via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 12 10:55:21 PDT 2023
rsandifo-arm added inline comments.
================
Comment at: clang/include/clang/Basic/AttributeCommonInfo.h:135
AttributeCommonInfo(const IdentifierInfo *AttrName,
const IdentifierInfo *ScopeName, SourceRange AttrRange,
----------------
erichkeane wrote:
> Did these two ctors swap places somehow? There's something goofy going on here? Or is this just to make the delegation of ctors more sensible?
Ah, yeah, I should have mentioned that, sorry. The most general constructor was previously the second in the list. Like you say, I moved it up to make the delegation more obvious. The other three keep their relative order.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148148/new/
https://reviews.llvm.org/D148148
More information about the cfe-commits
mailing list