[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 12 02:01:10 PDT 2023


asb added a comment.

Will `--[no-]relax-gp` make its way into a minor gcc point release or do we need to wait for the next major release?

In terms of this breaking GNU users - isn't it the case that without this option, they may get silently broken code when using the shadow call stack? Breaking loudly and early seems preferable, though of course it would be best if it's easily fixable by e.g. updating to a newer released binutils.

One slight tweak might be to avoid adding `--no-relax-gp` if linker relaxation is already disabled, though it's not going to matter once binutils gets support for --no-relax-gp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148034/new/

https://reviews.llvm.org/D148034



More information about the cfe-commits mailing list