[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 11 13:22:20 PDT 2023


MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

Sorry, we cannot do this. See https://reviews.llvm.org/D147983#4259132 
I added --[no-]relax-gp to GNU ld master branch recently, which isn't in a released binutils version yet.
Passing `--no-relax-gp` will break almost all GNU ld users.

For lld, we have made a decision to not enable global pointer relaxation by default, so this option isn't really needed.
It doesn't hurt to receive the option, though, once lld supports the options.

I wonder whether we can let GCC autoconf for certain `riscv*-` target triples (perhaps just some Linux's) detect `ld --relax-gp` support and set `--relax-gp` in linker specs and change GNU ld to default to `--no-relax-gp` in the future,
given someone's stance on https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/371


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148034/new/

https://reviews.llvm.org/D148034



More information about the cfe-commits mailing list