[PATCH] D147661: [Sema] Tweak merging of availability attributes

Mon Apr 10 04:50:51 PDT 2023

aaron.ballman commandeered this revision.
aaron.ballman edited reviewers, added: rsandifo-arm; removed: aaron.ballman.
aaron.ballman added a comment.

In D147661#4255043 <https://reviews.llvm.org/D147661#4255043>, @rsandifo-arm wrote:

>> I threw together a patch to make the constructors `explicit` and the only two compile failures I have are with what you're fixing in this patch. If you'd like, I can commandeer this patch and subsume it with the larger refactor. Alternatively, we can land this (I'd drop the test though) and I can rebase on top of your changes. Either is fine by me.
>
> Yeah, please feel free to commandeer it.  My original motivation for doing this was to remove the single-argument constructors rather than keep them.  However, I agree that making them explicit in the meantime would ensure forward progress, if what I'm doing in the follow-on patches turns out not to be acceptable.

Okay, thanks! I think getting rid of these constructors will be a bit of a challenge because of how many implicit attributes are created internally, but at the same time, I would not be sad if they disappeared either.

I'm commandeering this revision and will cite it in the commit message when I land the patch so there's a paper trail explaining how we got to those changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147661/new/

https://reviews.llvm.org/D147661