[PATCH] D147661: [Sema] Tweak merging of availability attributes

Richard Sandiford via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 10 02:49:45 PDT 2023


rsandifo-arm added a comment.

> I threw together a patch to make the constructors `explicit` and the only two compile failures I have are with what you're fixing in this patch. If you'd like, I can commandeer this patch and subsume it with the larger refactor. Alternatively, we can land this (I'd drop the test though) and I can rebase on top of your changes. Either is fine by me.

Yeah, please feel free to commandeer it.  My original motivation for doing this was to remove the single-argument constructors rather than keep them.  However, I agree that making them explicit in the meantime would ensure forward progress, if what I'm doing in the follow-on patches turns out not to be acceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147661/new/

https://reviews.llvm.org/D147661



More information about the cfe-commits mailing list