[PATCH] D147845: [clang][Interp] Fix a crash when calling invalid constexpr functions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 8 05:34:24 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/AST/Interp/functions.cpp:210-212
+      return 1 / 0; // expected-note 2{{division by zero}} \
+                    // expected-warning {{is undefined}} \
+                    // ref-note 2{{division by zero}} \
----------------
It'd be nice if we didn't issue duplicate notes in this case, but given that the behavior matches the reference implementation, it's reasonable enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147845/new/

https://reviews.llvm.org/D147845



More information about the cfe-commits mailing list