[PATCH] D147845: [clang][Interp] Fix a crash when calling invalid constexpr functions

[Timm Bäder via Phabricator via cfe-commits]

tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, shafik, erichkeane, tahonermann.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147845

Files:
  clang/lib/AST/Interp/InterpFrame.cpp
  clang/test/AST/Interp/functions.cpp


Index: clang/test/AST/Interp/functions.cpp
===================================================================
--- clang/test/AST/Interp/functions.cpp
+++ clang/test/AST/Interp/functions.cpp
@@ -202,3 +202,20 @@
 constexpr int doit() { return nyd(10); }
 constexpr int nyd(int m) { return m; }
 static_assert(doit() == 10, "");
+
+namespace InvalidCall {
+  struct S {
+    constexpr int a() const { // expected-error {{never produces a constant expression}} \
+                              // ref-error {{never produces a constant expression}}
+      return 1 / 0; // expected-note 2{{division by zero}} \
+                    // expected-warning {{is undefined}} \
+                    // ref-note 2{{division by zero}} \
+                    // ref-warning {{is undefined}}
+    }
+  };
+  constexpr S s;
+  static_assert(s.a() == 1); // expected-error {{not an integral constant expression}} \
+                             // expected-note {{in call to}} \
+                             // ref-error {{not an integral constant expression}} \
+                             // ref-note {{in call to}}
+}
Index: clang/lib/AST/Interp/InterpFrame.cpp
===================================================================
--- clang/lib/AST/Interp/InterpFrame.cpp
+++ clang/lib/AST/Interp/InterpFrame.cpp
@@ -127,7 +127,8 @@
   }
 
   // Drop the first pointer since we print it unconditionally anyway.
-  Levels.erase(Levels.begin());
+  if (!Levels.empty())
+    Levels.erase(Levels.begin());
 
   printDesc(P.getDeclDesc());
   for (const auto &It : Levels) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147845.511869.patch
Type: text/x-patch
Size: 1560 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230408/850d06d1/attachment.bin>