[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 28 14:17:48 PDT 2023
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66
+
+ const auto *FuncDecl = CExpr->getDirectCallee();
+ if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier())
----------------
PiotrZSL wrote:
> Eugene.Zelenko wrote:
> > Please do not use `auto` if type is not spelled explicitly or iterator.
> That `auto` already was there, I just moved it... :)
So it's great reason to finally fix it :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147081/new/
https://reviews.llvm.org/D147081
More information about the cfe-commits
mailing list