[PATCH] D147081: [clang-tidy] Fix issues in bugprone-assert-side-effect

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 28 14:15:23 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp:66
+
+  const auto *FuncDecl = CExpr->getDirectCallee();
+  if (!FuncDecl || !FuncDecl->getDeclName().isIdentifier())
----------------
Eugene.Zelenko wrote:
> Please do not use `auto` if type is not spelled explicitly or iterator.
That `auto` already was there, I just moved it... :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147081/new/

https://reviews.llvm.org/D147081



More information about the cfe-commits mailing list