[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

[Chris Cotter via Phabricator via cfe-commits]

ccotter added inline comments.
Herald added a subscriber: PiotrZSL.


================
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588
+    : ClangTidyCheck(Name, Context),
+      IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
+                                               utils::IncludeSorter::IS_LLVM),
----------------
Eugene.Zelenko wrote:
> ccotter wrote:
> > Eugene.Zelenko wrote:
> > > Should be global option, because it's used in other checks.
> > Could you clarify this a bit? This is how most other tests consume IncludeStyle (`Options.getLocalOrGlobal("IncludeStyle", utils::IncludeSorter::IS_LLVM)`.
> @carlosgalvezp is best person to answer because he recently introduced global option for source files and headers.
bump @carlosgalvezp 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145138/new/

https://reviews.llvm.org/D145138