[clang] 731264b - [clang][NFC] Fix location of 2>&1 in a few -print tests
Louis Dionne via cfe-commits
cfe-commits at lists.llvm.org
Sat Mar 25 12:57:56 PDT 2023
Author: Louis Dionne
Date: 2023-03-25T15:57:20-04:00
New Revision: 731264b0c2af7aa46bd39625202a99e06cfccff9
URL: https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9
DIFF: https://github.com/llvm/llvm-project/commit/731264b0c2af7aa46bd39625202a99e06cfccff9.diff
LOG: [clang][NFC] Fix location of 2>&1 in a few -print tests
While it's apparently valid to place Bash redirections anywhere in a
command-line, it is by far most frequently placed last. This changes
a few tests that did not conform to this convention and which I
originally thought were wrong.
Differential Revision: https://reviews.llvm.org/D146155
Added:
Modified:
clang/test/Driver/print-effective-triple.c
clang/test/Driver/print-file-name.c
clang/test/Driver/print-libgcc-file-name-clangrt.c
clang/test/Driver/print-multi-directory.c
clang/test/Driver/print-target-triple.c
Removed:
################################################################################
diff --git a/clang/test/Driver/print-effective-triple.c b/clang/test/Driver/print-effective-triple.c
index 65b38748d6a3..f621f20942bc 100644
--- a/clang/test/Driver/print-effective-triple.c
+++ b/clang/test/Driver/print-effective-triple.c
@@ -1,6 +1,6 @@
// Test that -print-target-triple prints correct triple.
-// RUN: %clang -print-effective-triple 2>&1 \
-// RUN: --target=thumb-linux-gnu \
+// RUN: %clang -print-effective-triple \
+// RUN: --target=thumb-linux-gnu 2>&1 \
// RUN: | FileCheck %s
// CHECK: armv4t-unknown-linux-gnu
diff --git a/clang/test/Driver/print-file-name.c b/clang/test/Driver/print-file-name.c
index d6dd7a8a57c8..fadb99a74143 100644
--- a/clang/test/Driver/print-file-name.c
+++ b/clang/test/Driver/print-file-name.c
@@ -1,19 +1,19 @@
// Test that -print-file-name finds the correct file.
-// RUN: %clang -print-file-name=share/asan_ignorelist.txt 2>&1 \
+// RUN: %clang -print-file-name=share/asan_ignorelist.txt \
// RUN: -resource-dir=%S/Inputs/resource_dir \
-// RUN: --target=x86_64-unknown-linux-gnu \
+// RUN: --target=x86_64-unknown-linux-gnu 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-RESOURCE-DIR %s
// CHECK-RESOURCE-DIR: resource_dir{{/|\\}}share{{/|\\}}asan_ignorelist.txt
-// RUN: %clang -print-file-name=libclang_rt.builtins.a 2>&1 \
+// RUN: %clang -print-file-name=libclang_rt.builtins.a \
// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
-// RUN: --target=x86_64-unknown-linux-gnu \
+// RUN: --target=x86_64-unknown-linux-gnu 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-COMPILER-RT %s
// CHECK-COMPILER-RT: resource_dir_with_per_target_subdir{{/|\\}}lib{{/|\\}}x86_64-unknown-linux-gnu{{/|\\}}libclang_rt.builtins.a
-// RUN: %clang -print-file-name=include/c++/v1 2>&1 \
+// RUN: %clang -print-file-name=include/c++/v1 \
// RUN: -ccc-install-dir %S/Inputs/basic_linux_libcxx_tree/usr/bin \
-// RUN: --target=x86_64-unknown-linux-gnu \
+// RUN: --target=x86_64-unknown-linux-gnu 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-INSTALL-DIR %s
// CHECK-INSTALL-DIR: basic_linux_libcxx_tree{{/|\\}}usr{{/|\\}}bin{{/|\\}}..{{/|\\}}include{{/|\\}}c++{{/|\\}}v1
diff --git a/clang/test/Driver/print-libgcc-file-name-clangrt.c b/clang/test/Driver/print-libgcc-file-name-clangrt.c
index d5e7c48dde29..19f9a3c28c31 100644
--- a/clang/test/Driver/print-libgcc-file-name-clangrt.c
+++ b/clang/test/Driver/print-libgcc-file-name-clangrt.c
@@ -1,65 +1,65 @@
// Test that -print-libgcc-file-name correctly respects -rtlib=compiler-rt.
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=x86_64-pc-linux \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-X8664 %s
// CHECK-CLANGRT-X8664: libclang_rt.builtins-x86_64.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=i386-pc-linux \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I386 %s
// CHECK-CLANGRT-I386: libclang_rt.builtins-i386.a
// Check whether alternate arch values map to the correct library.
//
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=i686-pc-linux \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-I386 %s
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=arm-linux-gnueabi \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARM %s
// CHECK-CLANGRT-ARM: libclang_rt.builtins-arm.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=arm-linux-androideabi \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARM-ANDROID %s
// CHECK-CLANGRT-ARM-ANDROID: libclang_rt.builtins-arm-android.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=arm-linux-gnueabihf \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARMHF %s
// CHECK-CLANGRT-ARMHF: libclang_rt.builtins-armhf.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=arm-linux-gnueabi -mfloat-abi=hard \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARM-ABI %s
// CHECK-CLANGRT-ARM-ABI: libclang_rt.builtins-armhf.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=armv7m-none-eabi \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARM-BAREMETAL %s
// CHECK-CLANGRT-ARM-BAREMETAL: libclang_rt.builtins-armv7m.a
-// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name 2>&1 \
+// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \
// RUN: --target=armv7m-vendor-none-eabi \
// RUN: --sysroot=%S/Inputs/resource_dir_with_arch_subdir \
-// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir \
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-CLANGRT-ARM-BAREMETAL-PER-TARGET %s
// CHECK-CLANGRT-ARM-BAREMETAL-PER-TARGET: libclang_rt.builtins.a
diff --git a/clang/test/Driver/print-multi-directory.c b/clang/test/Driver/print-multi-directory.c
index 46e9ba5ba895..11741e76d606 100644
--- a/clang/test/Driver/print-multi-directory.c
+++ b/clang/test/Driver/print-multi-directory.c
@@ -1,27 +1,27 @@
-// RUN: %clang -### %s 2>/dev/null \
+// RUN: %clang -### %s \
// RUN: --target=i386-none-linux \
// RUN: --sysroot=%S/Inputs/multilib_64bit_linux_tree/usr \
-// RUN: -print-multi-directory \
+// RUN: -print-multi-directory 2>/dev/null \
// RUN: | FileCheck --match-full-lines --check-prefix=CHECK-X86-MULTILIBS %s
// CHECK-X86-MULTILIBS: 32
// CHECK-X86-MULTILIBS-NOT: {{^.+$}}
-// RUN: %clang -### %s 2>/dev/null \
+// RUN: %clang -### %s \
// RUN: --target=i386-none-linux -m64 \
// RUN: --sysroot=%S/Inputs/multilib_64bit_linux_tree/usr \
-// RUN: -print-multi-directory \
+// RUN: -print-multi-directory 2>/dev/null \
// RUN: | FileCheck --match-full-lines --check-prefix=CHECK-X86_64-MULTILIBS %s
// CHECK-X86_64-MULTILIBS: .
// CHECK-X86_64-MULTILIBS-NOT: {{^.+$}}
-// RUN: %clang -### %s 2>/dev/null \
+// RUN: %clang -### %s \
// RUN: --target=arm-linux-androideabi21 \
// RUN: -mthumb \
// RUN: --gcc-toolchain=%S/Inputs/basic_android_ndk_tree \
// RUN: --sysroot=%S/Inputs/basic_android_ndk_tree/sysroot \
-// RUN: -print-multi-directory \
+// RUN: -print-multi-directory 2>/dev/null \
// RUN: | FileCheck --match-full-lines --check-prefix=CHECK-ARM-MULTILIBS %s
// CHECK-ARM-MULTILIBS: thumb
diff --git a/clang/test/Driver/print-target-triple.c b/clang/test/Driver/print-target-triple.c
index 70b2493a6fae..3b15f44d4d9c 100644
--- a/clang/test/Driver/print-target-triple.c
+++ b/clang/test/Driver/print-target-triple.c
@@ -1,6 +1,6 @@
// Test that -print-target-triple prints correct triple.
-// RUN: %clang -print-target-triple 2>&1 \
-// RUN: --target=x86_64-linux-gnu \
+// RUN: %clang -print-target-triple \
+// RUN: --target=x86_64-linux-gnu 2>&1 \
// RUN: | FileCheck %s
// CHECK: x86_64-unknown-linux-gnu
More information about the cfe-commits
mailing list