[PATCH] D144651: [Serialization] Place command line defines in the correct file

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D144651#4219633 <https://reviews.llvm.org/D144651#4219633>, @fdeazeve wrote:

> In D144651#4219340 <https://reviews.llvm.org/D144651#4219340>, @aaron.ballman wrote:
>
>> The build lab's lldb builders are all green, and greendragon's standalone build is also green. Could this be a problem with incremental builds being in a bad state somehow?
>
> I don't think so, as I can reliably reproduce this on my machine. I believe the _contents_ of the SDK headers affect what is fed to Clang, and therefore we see the crash with some SDKs but not others.

Ouch. :-( I think we're going to need some help getting a reproducer that doesn't rely on the SDK headers. In the meantime, because this is causing disruption by introducing a crash, I think it's fine to revert the changes until @john.brawn returns from vacation, but I'd appreciate it if we had such a reproducer in hand fairly shortly (I don't want to stick John in a position where his patch was reverted and he has no reasonable way in which to address the issue so it can be re-landed).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144651/new/

https://reviews.llvm.org/D144651