[PATCH] D144651: [Serialization] Place command line defines in the correct file

Fri Mar 24 08:13:20 PDT 2023

fdeazeve added a comment.

In D144651#4219340 <https://reviews.llvm.org/D144651#4219340>, @aaron.ballman wrote:

> In D144651#4217750 <https://reviews.llvm.org/D144651#4217750>, @john.brawn wrote:
>
>> Unfortunately I still can't reproduce this even using exactly the same cmake command as you gave. Looking at above cmake log some possible causes of difference are:
>>
>> - I'm doing this on an M1 <https://reviews.llvm.org/M1> macbook with host triple arm64-apple-darwin21.6.0 but the host triple on that bot is x86_64-apple-darwin20.6.0
>> - I'm using python 3.9, bot is using python 3.10
>> - I'm doing a build from clean whereas the bot is doing an incremental build
>>
>> Also if I try to run the simpler reproducer you give then I get the error
>>
>>   error: expression failed to parse:
>>   error: Header search couldn't locate module Cocoa
>>
>> I'm now on holiday, I won't be able to get back to this until 2023-04-03.
>
> The build lab's lldb builders are all green, and greendragon's standalone build is also green. Could this be a problem with incremental builds being in a bad state somehow?

I don't think so, as I can reliably reproduce this on my machine. I believe the _contents_ of the SDK headers affect what is fed to Clang, and therefore we see the crash with some SDKs but not others.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144651/new/

https://reviews.llvm.org/D144651