[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

[Ziqing Luo via Phabricator via cfe-commits]

ziqingluo-90 added inline comments.


================
Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2203
+    if (IsRelatedToDecl) {
+      assert(!SuggestSuggestions &&
+             "Variables blamed for unsafe buffer usage without suggestions!");
----------------
nitpick: 
I was a bit confused by the name of the variable.  My understand of 
`!SuggestSuggestions ` here means "we are suggesting suggestions now".  
Then what does `SuggestSuggestions ` mean?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146669/new/

https://reviews.llvm.org/D146669