[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

Ziqing Luo via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 23 11:50:44 PDT 2023


ziqingluo-90 added inline comments.


================
Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1139
                                    UnsafeBufferUsageHandler &Handler,
+                                   bool EmitSuggestions,
                                    bool EmitFixits) {
----------------
nitpick: I'm afraid that we will forgot the difference between `EmitSuggestions` and `EmitFixits` later if there is no document about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146669/new/

https://reviews.llvm.org/D146669



More information about the cfe-commits mailing list