[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

Qiongsi Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 23 10:02:50 PDT 2023


qiongsiwu1 updated this revision to Diff 507752.
qiongsiwu1 added a comment.

Address code review. Thanks for your comments/suggestions @MaskRay !!

- Fixing comments.
- Using `--target=` in tests.
- Reducing number of RUN lines in tests.

@hubert.reinterpretcast I ended up having a mix of tests for 32 and 64 bit targets as @MaskRay suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144190/new/

https://reviews.llvm.org/D144190

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Basic/CodeGenOptions.def
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/include/clang/Driver/Options.td
  clang/lib/CodeGen/BackendUtil.cpp
  clang/lib/Driver/ToolChains/AIX.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Driver/ToolChains/CommonArgs.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/test/CodeGen/PowerPC/aix-roptr.c
  clang/test/Driver/ppc-roptr.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144190.507752.patch
Type: text/x-patch
Size: 12427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230323/9432d177/attachment.bin>


More information about the cfe-commits mailing list