[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

[Qiongsi Wu via Phabricator via cfe-commits]

qiongsiwu1 added inline comments.


================
Comment at: clang/test/Driver/ppc-roptr.c:21
+// RUN:     FileCheck %s --check-prefix=ROPTR
+// RUN: %clang -### -target powerpc64-ibm-aix-xcoff -S -mroptr %s 2>&1 | \
+// RUN:     FileCheck %s --check-prefix=ROPTR
----------------
MaskRay wrote:
> I feel that there are too many RUN lines. Every little makes. Can you reduce the numbers? For example
> 
> In many cases it isn't necessary to test every combination with both -S/-c. Testing one suffices.
> 
> When you test 4 combinations of two factors, e,g.
> ```
> %clang a c
> %clang a d
> %clang b c
> %clang b d
> ```
> In many times two RUN lines are sufficient:
> ```
> %clang a c
> %clang b d
> ```
Thanks for the comment! 

@hubert.reinterpretcast do you think it is sufficient to test `-c` only (removing the `-S` tests) and to test `powerpc64` only (removing the `powerpc` targets)? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144190/new/

https://reviews.llvm.org/D144190