[PATCH] D144651: [Serialization] Place command line defines in the correct file

[Felipe de Azevedo Piovezan via Phabricator via cfe-commits]

fdeazeve added a comment.

> It looks like green.lab.llvm.org is down, so can't look at that log, but doing a local build and test of lldb (on a macbook, as this test is only enabled on macos) I don't see this failure, or any other tests failing with this assertion.

It should be back online now: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52729/console

  Unresolved Tests (20):
    lldb-api :: commands/expression/import-std-module/array/TestArrayFromStdModule.py
    lldb-api :: commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py
    lldb-api :: commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py
    lldb-api :: commands/expression/import-std-module/forward_list-dbg-info-content/TestDbgInfoContentForwardListFromStdModule.py
    lldb-api :: commands/expression/import-std-module/forward_list/TestForwardListFromStdModule.py
    lldb-api :: commands/expression/import-std-module/iterator/TestIteratorFromStdModule.py
    lldb-api :: commands/expression/import-std-module/list-dbg-info-content/TestDbgInfoContentListFromStdModule.py
    lldb-api :: commands/expression/import-std-module/list/TestListFromStdModule.py
    lldb-api :: commands/expression/import-std-module/non-module-type-separation/TestNonModuleTypeSeparation.py
    lldb-api :: commands/expression/import-std-module/queue/TestQueueFromStdModule.py
    lldb-api :: commands/expression/import-std-module/retry-with-std-module/TestRetryWithStdModule.py
    lldb-api :: commands/expression/import-std-module/shared_ptr-dbg-info-content/TestSharedPtrDbgInfoContentFromStdModule.py
    lldb-api :: commands/expression/import-std-module/shared_ptr/TestSharedPtrFromStdModule.py
    lldb-api :: commands/expression/import-std-module/unique_ptr-dbg-info-content/TestUniquePtrDbgInfoContent.py
    lldb-api :: commands/expression/import-std-module/unique_ptr/TestUniquePtrFromStdModule.py
    lldb-api :: commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py
    lldb-api :: commands/expression/import-std-module/vector-of-vectors/TestVectorOfVectorsFromStdModule.py
    lldb-api :: commands/expression/import-std-module/weak_ptr-dbg-info-content/TestDbgInfoContentWeakPtrFromStdModule.py
    lldb-api :: commands/expression/import-std-module/weak_ptr/TestWeakPtrFromStdModule.py
    lldb-api :: commands/expression/import_builtin_fileid/TestImportBuiltinFileID.py

Locally, I can make the last test on this list crash reliably. I've also confirmed that, on the bot, reverting this patch fixes the other tests as well.
Could you share your CMake invocation? This is what I used:

  build_type=Debug
  cmake \
    -S llvm/ -B $build_dir/ \
    -G Ninja \
    -DLLVM_ENABLE_PROJECTS="clang;llvm;lldb" \
    -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" \
    -DLLVM_OPTIMIZED_TABLEGEN=TRUE \
    -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE \
    -DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" \
    -DCMAKE_BUILD_TYPE=$build_type
  
  cmake --build $build_dir
  build_Debug/bin/llvm-lit -v lldb/test/API/commands/expression/import_builtin_fileid/TestImportBuiltinFileID.py

This also works for a simpler repro:

  build=build_Debug
  rm -rf artifacts
  mkdir artifacts
  $build/bin/clang -g -O0 -fmodules -gmodules lldb/test/API/commands/expression/import_builtin_fileid/main.m -o artifacts/a.out
  $build/bin/lldb artifacts/a.out -o 'b 4' -o run -o 'expr int (*DBG_CGImageGetRenderingIntent)(void *) = ((int (*)(void *))CGImageGetRenderingIntent);'

If you have lldb in your machine, you can also run lldb itself on lldb by prefixing that last command with `lldb --`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144651/new/

https://reviews.llvm.org/D144651