[PATCH] D144651: [Serialization] Place command line defines in the correct file

Wed Mar 22 10:48:24 PDT 2023

john.brawn added a comment.

In D144651#4210787 <https://reviews.llvm.org/D144651#4210787>, @fdeazeve wrote:

> According to git-bisect, this patch is causing the LLDB bots to crash.
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/52690/console
>
> (They were failing for other reasons before, which is why it took a while for this to be identified)
>
> Clang is crashing with: `Assertion failed: (0 && "Invalid SLocOffset or bad function choice"`
>
> In particular, this is true for the test `lldb-api :: commands/expression/import_builtin_fileid/TestImportBuiltinFileID.py`
> I'm currently investigating the other failures reported by the bot, but we've also seen this assert fire internally in some other flows.

It looks like green.lab.llvm.org is down, so can't look at that log, but doing a local build and test of lldb (on a macbook, as this test is only enabled on macos) I don't see this failure, or any other tests failing with this assertion.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144651/new/

https://reviews.llvm.org/D144651