[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/lib/Analysis/FlowSensitive/Logger.cpp:17
+Logger &Logger::null() {
+  struct NullLogger : Logger {};
+  static auto *Instance = new NullLogger();
----------------
Adding `final`? Just in case it can help with devirtualization. 


================
Comment at: clang/lib/Analysis/FlowSensitive/Logger.cpp:23
+namespace {
+struct TextualLogger : Logger {
+  llvm::raw_ostream &OS;
----------------
`final`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144730/new/

https://reviews.llvm.org/D144730