[PATCH] D144730: [FlowSensitive] Log analysis progress for debugging purposes

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:186
+  Logger &logger() const {
+    return DACtx->getOptions().Log ? *DACtx->getOptions().Log : Logger::null();
+  }
----------------
If we already have a `NullLogger`, I wonder if making `DACtx->getOptions().Log` a reference that points to NullLogger when logging is disabled would be less confusing (and fewer branches).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144730/new/

https://reviews.llvm.org/D144730