[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

[Stanislav Gatev via Phabricator via cfe-commits]

sgatev accepted this revision.
sgatev added inline comments.


================
Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:52
+  /// Returns whether `B` is reachable from the entry block.
+  bool isBlockReachable(const CFGBlock *B) const {
+    return BlockReachable[B->getBlockID()];
----------------
What do you think about making this a const reference? Alternatively, let's document that it must not be null?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146514/new/

https://reviews.llvm.org/D146514