[PATCH] D146514: [clang][dataflow] Fix crash when RHS of `&&` or `||` calls `noreturn` func.

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 21 04:33:38 PDT 2023


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:399
+template <class ValueT>
+ValueT &getValueFromDecl(ASTContext &ASTCtx, const Environment &Env,
+                         llvm::StringRef Name) {
----------------
getValueForDecl?

A value corresponds to a decl, a value for the decl.

"From" suggests that the value is inside the decl, or that we transform the decl into a value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146514/new/

https://reviews.llvm.org/D146514



More information about the cfe-commits mailing list