[PATCH] D144651: [Serialization] Place command line defines in the correct file

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 17 08:31:58 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, though you should also add a release note for the fix.



================
Comment at: clang/lib/Serialization/ASTReader.cpp:1593
+    if (Record[3]) {
+      SrcMgr::FileInfo &FileInfo =
+          const_cast<SrcMgr::FileInfo &>(SourceMgr.getSLocEntry(FID).getFile());
----------------
No need to repeat the type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144651/new/

https://reviews.llvm.org/D144651



More information about the cfe-commits mailing list