[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

Mon Mar 13 15:34:38 PDT 2023

xazax.hun added a comment.

Do you plan to selectively enable warnings coming from the STL to catch misuses of certain STL types?

I think we should probably discuss this direction first. It is, in general, a fragile approach. Users might use Clang with GCC's, LLVM's, or MSVC's standard library. Today, we do not have the means to ensure that these checks continue to work as expected on all STL implementations over time. Also, those warning reports might be leaky in a sense the reported path might contain implementations details from the STL that is hard to interpret.

I am afraid, if we want to provide a good user experience, we might be doomed to manually simulate the behavior of STL classes.

What do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145069/new/

https://reviews.llvm.org/D145069