[PATCH] D145069: [analyzer][NFC] Split the no state change logic and bug report suppression into two visitors

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:449
   // No diagnostic if region was modified inside the frame.
   if (!CallExitLoc || isModifiedInFrame(N))
     return nullptr;
----------------
We also lost this, unfortunately, and this is kind of the point where we check whether the std function has anything to do with the uninitialized value (its been passed as parameter or something).

Please investigate whether losing this has any effect (and it very likely does).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145069/new/

https://reviews.llvm.org/D145069