[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705
Mike Crowe via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 10 05:08:15 PST 2023
mikecrowe added a comment.
In D145730#4182949 <https://reviews.llvm.org/D145730#4182949>, @PiotrZSL wrote:
> Also consider reducing commit message, instead just copying issue description.
> Simple description about issue would be sufficient.
TBH, I wasn't expecting this change to be accepted. I was merely hoping that it would cause someone to give me a hint as to how to fix it properly. That's why I included so much information in the commit message. I will shorten the commit message.
> No functional issues, so LGTM.
Thanks for the review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145730/new/
https://reviews.llvm.org/D145730
More information about the cfe-commits
mailing list