[PATCH] D145730: [clang-tidy] readability-redundant-string-cstr for smart pointer #576705

[Piotr Zegar via Phabricator via cfe-commits]

PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.

Also consider reducing commit message, instead just copying issue description.
Simple description about issue would be sufficient.

No functional issues, so LGTM.



================
Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:56
+
+  // https://github.com/llvm/llvm-project/issues/56705
+  Text.consume_back("->");
----------------
You don't need to reference issue (it's already in commit message) here, better comment like "// Removing remaining '->' from overloaded operator call"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145730/new/

https://reviews.llvm.org/D145730