[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays
Eugene Zelenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 2 20:19:04 PST 2023
Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588
+ : ClangTidyCheck(Name, Context),
+ IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
+ utils::IncludeSorter::IS_LLVM),
----------------
ccotter wrote:
> Eugene.Zelenko wrote:
> > Should be global option, because it's used in other checks.
> Could you clarify this a bit? This is how most other tests consume IncludeStyle (`Options.getLocalOrGlobal("IncludeStyle", utils::IncludeSorter::IS_LLVM)`.
@carlosgalvezp is best person to answer because he recently introduced global option for source files and headers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145138/new/
https://reviews.llvm.org/D145138
More information about the cfe-commits
mailing list