[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

Chris Cotter via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 2 19:47:12 PST 2023


ccotter marked 2 inline comments as done.
ccotter added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588
+    : ClangTidyCheck(Name, Context),
+      IncludeInserter(Options.getLocalOrGlobal("IncludeStyle",
+                                               utils::IncludeSorter::IS_LLVM),
----------------
Eugene.Zelenko wrote:
> Should be global option, because it's used in other checks.
Could you clarify this a bit? This is how most other tests consume IncludeStyle (`Options.getLocalOrGlobal("IncludeStyle", utils::IncludeSorter::IS_LLVM)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145138/new/

https://reviews.llvm.org/D145138



More information about the cfe-commits mailing list