[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 26 14:38:25 PST 2023


owenpan added a comment.

Should we revert this patch?



================
Comment at: clang/unittests/Format/FormatTest.cpp:5175
   verifyFormat("#pragma omp threadprivate( \\\n"
-               "    y)), // expected-warning",
+               "        y)), // expected-warning",
                getLLVMStyleWithColumns(28));
----------------
Why was this test case changed? It seemed to be related to the regression mentioned in D136100#3988574.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136100/new/

https://reviews.llvm.org/D136100



More information about the cfe-commits mailing list