[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

Kugan Vivekanandarajah via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 23 01:36:38 PST 2023


kuganv added a comment.



> if you don't mind me asking, are you deliberately building remote-index components? i.e. do you have an internal remote-index server/deployment ? Asking as it'd be great to know that we've adoption here, outside of ourselves.
>
> OTOH, if you're not actually using it, this shouldn't be built unless `-DCLANGD_ENABLE_REMOTE=1 ` is part of the build config, hence we might have a bug in the build configuration and I'd like to make sure it's fixed.

Thanks for looking into it. Yes, we use -DCLANGD_ENABLE_REMOTE=On and provide grpc path with -DGRPC_INSTALL_PATH.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144599/new/

https://reviews.llvm.org/D144599



More information about the cfe-commits mailing list