[PATCH] D144599: [clangd/index/remote]NFC: Adapt code to newer grpc/protobuf versions

Thu Feb 23 01:19:48 PST 2023

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, indeed the protobuf version used by grpc-1.36.3 has these available, https://github.com/protocolbuffers/protobuf/blob/19fb89416f3fdc2d6668f3738f444885575285bc/src/google/protobuf/stubs/status.h.

if you don't mind me asking, are you deliberately building remote-index components? i.e. do you have an internal remote-index server/deployment ? Asking as it'd be great to know that we've adoption here, outside of ourselves.

OTOH, if you're not actually using it, this shouldn't be built unless `-DCLANGD_ENABLE_REMOTE=1 ` is part of the build config, hence we might have a bug in the build configuration and I'd like to make sure it's fixed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144599/new/

https://reviews.llvm.org/D144599